fix: restore typescript extension support #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdJoPaTo
changed the title
|
Confirmed to work. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #763
As far as I understand the updated rule checks for the listed extensions and only allows the listed ones now.
jswasn't included and therefore assumed as forbidden.As the rule was improved the reason for these custom options in gone now. It automatically assumes
jsfortsnow.https://github.com/eslint-community/eslint-plugin-n/blob/master/docs/rules/file-extension-in-import.md mentions
typescriptExtensionMapbut the default one seems to be fine so no need to configure it.