Skip to content

Fixed broken build, made file paths OS-agnostic #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

chriscarrollsmith
Copy link
Contributor

  • Updated dependencies
  • Replaced clifier with click because clifier is unmaintained and was forcing pyyaml to an old version that breaks the poetry build
  • Made file path handling OS-agnostic so tests will pass on Windows

@chriscarrollsmith
Copy link
Contributor Author

Also removed the tests for Python versions prior to 3.12. While backward-compatibility with old Python versions is an admirable goal, poetry handles this by forcing dependencies to the last version that was compatible with the earliest of the Python versions you want to support. In projects that use numpy, this unfortunately breaks compatibility with Python 3.12. (3.12 comes bundled with numpy >2.0, and an error gets thrown if poetry tries to install a version older than that as a project dependency. It's a whole thing. But the long and short of it is that even if your tests pass on >3.12, most users of >3.12 won't be able to install the project.)

@xnuinside
Copy link
Owner

@chriscarrollsmith thanks for opening the pr, I will check tomorrow and merge

@chriscarrollsmith
Copy link
Contributor Author

Sorry; thought I had already pushed the fix for that error.

@xnuinside
Copy link
Owner

@chriscarrollsmith thanks for the PR!

@xnuinside xnuinside merged commit 1e541dc into xnuinside:main Oct 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants