Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Rust 2024 #1654

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Migrate to Rust 2024 #1654

wants to merge 9 commits into from

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Feb 21, 2025 •
edited
Loading

fixes lints affecting #1651 & #1647

@insipx insipx requested a review from a team as a code owner February 21, 2025 12:17
@insipx insipx requested a review from codabrink February 21, 2025 16:43
mchenani
mchenani approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🧹

codabrink
codabrink requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@codabrink codabrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just gonna block this for a second while #1621 is in the works 😄 let's merge it right after. I'll get 1621 in asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codabrink codabrink codabrink requested changes

@mchenani mchenani mchenani approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@insipx @codabrink @mchenani