Skip to content
This repository was archived by the owner on Feb 28, 2025. It is now read-only.

Fetch Key Packages Companion #41

Merged
merged 9 commits into from
Feb 8, 2024
Merged

Fetch Key Packages Companion #41

merged 9 commits into from
Feb 8, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Feb 2, 2024

updates some methods to make it easier to use queries, so should be merged after #39 so I can update this

@insipx insipx marked this pull request as draft February 2, 2024 22:10
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (64b6ca7) 96.67% compared to head (fa227e9) 97.28%.

Files Patch % Lines
lib/src/error.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   96.67%   97.28%   +0.61%     
==========================================
  Files          13       13              
  Lines        2704     2833     +129     
==========================================
+ Hits         2614     2756     +142     
+ Misses         90       77      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Let me know once you want an actual review - I can never tell with these draft reviews....

@insipx insipx marked this pull request as ready for review February 7, 2024 15:44
Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🔥🚀

@jac18281828
Copy link
Contributor

Some code is missing coverage. It would be worthwhile to write small tests for that.

@insipx insipx merged commit 02a0e91 into main Feb 8, 2024
@insipx insipx deleted the insipx/fetch-key-packages branch February 8, 2024 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants