Allow configurable timeout on Connection

[silverbucket]

The framework for passing in options was already there, I just added the possibility for a user-defined timeout.

[silverbucket]

What do you think @sonnyp can we get this merged and a release made?

[sonnyp]

Thanks for the contribution. Can you help me understand why you need this?

[silverbucket]

@sonnyp well, it seems like the groundwork was already laid for this, just a matter of giving the user the ability to set longer timeouts for connect. Imagine bad latency or unresponsive/slow server response. The default of 2s might not be enough time.

[silverbucket]

For more context, in sockethub, we are adding the ability to allow for setting a custom a connect timeout if needed, as everyones network conditions vary. Done for IRC, and HTTP Fetches, just need the ability for XMPP. sockethub/sockethub#894

[sonnyp]

Thanks for the context.

timeout isn't an exposed option at the moment
I don't think this works the way you think it does.

A bit more work/testing is needed

[silverbucket]

@sonnyp you're right, it could be simplified. I was trying to go along with the way the options were handled, but now see that while it worked, it was unnecessary.
I've just pushed changes, and have added tests.

[silverbucket]

ping @sonnyp this PR is ready for another look, I've addressed your concerns.