librime: add package #8227
librime: add package #8227
Conversation
Summary of ChangesHello @black-desk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new package for librime. The package definition is well-structured. I have a couple of suggestions to improve it. First, to speed up builds, it's better to disable building tests and samples via CMake flags. Second, for better portability on Linux and BSD, explicitly linking pthread is recommended, following the pattern of other packages in this repository.
|
need gtest |
black-desk
force-pushed
the
add-librime
branch
2 times, most recently
from
fa8c862 to
1602fa3
Compare
if(BUILD_TEST)
find_package(GTest REQUIRED)
if(GTEST_FOUND)
enable_testing()
include_directories(${GTEST_INCLUDE_DIRS})
endif()
endif()just |
black-desk
force-pushed
the
add-librime
branch
from
1602fa3 to
24f0094
Compare
|
| table.insert(configs, "-DENABLE_ASAN=" .. (package:config("asan") and "ON" or "OFF")) | ||
| import("package.tools.cmake").install(package, configs) | ||
| -- Can't use `extern "C"` in c code | ||
| if package:config("shared") then |
There was a problem hiding this comment.
Should we sent this change to upstream?
There was a problem hiding this comment.
Done rime/librime#1083
| -- end | ||
| -- Can't use `extern "C"` in c code | ||
| if package:config("shared") then | ||
| io.replace(path.join(package:installdir("include"), "rime_api.h"), [[extern "C" RIME_DLL]], "RIME_DLL", {plain = true}) |
There was a problem hiding this comment.
Will there be any issues when including with C++? Or is it okay because there's extern "C" {} outside?
There was a problem hiding this comment.
Only c++ support the extern "C" syntax.
No description provided.