(gettext) add version 0.22.5 0.23.1 0.24.1 and 0.25 and fix libiconv #7049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Arthapz
commented
May 1, 2025
Arthapz
commented
- Before adding new features and new modules, please go to issues to submit the relevant feature description first.
- Write good commit messages and use the same coding conventions as the rest of the project.
- Please commit code to dev branch and we will merge into master branch in feature
- Ensure your edited codes with four spaces instead of TAB.
- 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
- 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
- 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
- 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。
Should sh.exe be covered by |
yeah it should, but i don't know how |
if is_subhost("windows") then
import("package.tools.autoconf")
local envs = autoconf.buildenvs(package)
envs.PATH = "C:/PROGRA~1/Git/usr/bin" .. path.envsep() .. envs.PATH
autoconf.install(package, configs, {envs = envs, cflags = cflags, ldflags = ldflags})
else
import("package.tools.autoconf").install(package, configs, {cflags = cflags, ldflags = ldflags})
endMaybe there is some solution like this. Or either this if is_subhost("windows") then
import("package.tools.autoconf")
import("lib.detect.find_tool")
local git = assert(find_tool("git"), "git tool not found!")
print("git => ")
print(git)
local git_folder = path.directory(path.directory(git.program))
print("Git => " .. git_folder)
local sh = "sh.exe"
for _, file in ipairs(os.files(path.join(git_folder, "usr", "bin", "**sh.exe"))) do
if path.filename(file) == "sh.exe" then
print(file)
sh = file:replace("Program Files (x86)", "PROGRA~2"):replace("Program Files", "PROGRA~1")
print(sh)
end
end
local envs = autoconf.buildenvs(package)
envs.PATH = path.directory(sh)
print(envs)
autoconf.install(package, configs, {envs = envs, cflags = cflags, ldflags = ldflags})
else
import("package.tools.autoconf").install(package, configs, {cflags = cflags, ldflags = ldflags})
endso it would be |
ok thx, i think i have a fix |
Arthapz
force-pushed
the
update-gettext
branch
9 times, most recently
from
df9723c to
e580e76
Compare
Arthapz
changed the title
|
ok it work for the sh path, but know we have link issues :D |
Arthapz
force-pushed
the
update-gettext
branch
12 times, most recently
from
d5e0316 to
aec0373
Compare
Arthapz
force-pushed
the
update-gettext
branch
2 times, most recently
from
642c8a9 to
91aa559
Compare
Arthapz
force-pushed
the
update-gettext
branch
9 times, most recently
from
7d9a143 to
41bc56e
Compare
Arthapz
force-pushed
the
update-gettext
branch
2 times, most recently
from
0673e63 to
e59b623
Compare
|
@luadebug finally it's working \o/ |
runv will check retval, and raise error if it's non-zero. but exec will return retval directly, it will not check it. so make process maybe has non-zero exit value. |
i've put assert on exec, and it doesn't activate, so execv return a zero exit value, this is black magic |
|
so, should i make any changes ? or is it mergeable ? |
Arthapz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.