Symbols/fix key merge mode symbols x11 #591
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds tests for merging various key configurations: - With/without keysyms/actions - Single/multiple keysyms/actions per level We test all the merge modes for including a map: - default (include) - augment - override - replace The tests data are generated with: - A Python script `scripts/update-symbols-tests.py` for keycodes and symbols data. It can optionally generate C headers for alternative key sequence tests, that were used before implementing golden tests. - The `merge-modes` test generates its own keymap files for golden test, using: `build/test-merge-modes update`.
We also test against xkbcomp so we can compare its handling of merge modes with xkbcommon. Unfortunately, there are currently some differences due to xkbcomp discarding trailing `NoSymbol`. Thus there are 2 keymaps sets for the golden sets: X11 and xkbcommon.
It seems that the X11 tests trigger an out-of-bounds bug in xkbcomp. See: https://gitlab.freedesktop.org/xorg/app/xkbcomp/-/merge_requests/26
wismill
added
testing
This was referenced Jan 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #568 with test for X11 xkbcomp.
Require rebasing