Skip to content

fix inclusion of rnnoise.h into C++ code #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2021
Merged

fix inclusion of rnnoise.h into C++ code #131

merged 1 commit into from
Jan 18, 2021

Conversation

j-schultz
Copy link
Contributor

FIxes #120

@winstondu
Copy link

@jmvalin , this is very much needed! Please approve!

@petterreinholdtsen petterreinholdtsen mentioned this pull request Jan 18, 2021
Closed
@petterreinholdtsen
Copy link
Contributor

This change partly conflicts with the changes in pull request #88.

@j-schultz
Copy link
Contributor Author

The changes to rnnoise.h could be dropped in #88 for a cleaner separation of PRs, or #88 could be merged as-is and #131 could be closed instead. It doesn't really matter to me.

@petterreinholdtsen petterreinholdtsen merged commit 125d8a5 into xiph:master Jan 18, 2021
@petterreinholdtsen
Copy link
Contributor

I take the chance and merge this one, which will invalidate #88 until it is rebased.

@petterreinholdtsen petterreinholdtsen mentioned this pull request Jan 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include headers missing extern C
3 participants
@j-schultz @winstondu @petterreinholdtsen