Fix macOS framework builds #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

antonc27 wants to merge 1 commit into xiph:main from antonc27:patch-1

antonc27 commented Oct 25, 2025

This PR fixes 2 issues with CI builds of macOS framework:

Correct flag should be OPUS_BUILD_FRAMEWORK, not BUILD_FRAMEWORK.
Correct CMAKE_OSX_ARCHITECTURES should be set, otherwise host arch will be used.

P.S.

2 more thoughts:

I haven't checked myself, but iOS framework should also use OPUS_BUILD_FRAMEWORK, not BUILD_FRAMEWORK
FRAMEWORK_VERSION in cmake list should be probably set to "A" (major verison), not ${PROJECT_VERSION}


          Fix macOS framework builds

b22b895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet