perf: batch preset skill toggles - #336
Open
vipinchan wants to merge 1 commit into
Open
Conversation
- skill_store: 新增 batch_add_skills_to_scenario / batch_remove_skills_from_scenario, 单事务内完成批量 INSERT/DELETE - presets: 新增 batch_toggle_preset_skills Tauri 命令,metadata 写 1 次 + tray 刷 1 次 - lib.rs: 注册 batch_toggle_preset_skills - tauri.ts: 新增 batchTogglePresetSkills API - MySkills.tsx: handleBatchTogglePreset 从 N 次独立 IPC 改为 1 次批量调用 - N 选 30 时: 30 次 IPC + metadata 写入 + tray 重建 → 1 次
This was referenced Jul 22, 2026
vipinchan
force-pushed
the
perf/batch-preset-skill-toggle
branch
from
July 26, 2026 16:58
1a719cd to
4a24f89
Compare
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The current multi-select preset action loops over selected skills and performs N sequential IPC calls. This change reduces that to one backend call and one metadata write while preserving semantics.
This addresses the batch operation portion of #295.
Test plan
npm run buildcargo test --manifest-path src-tauri/Cargo.tomlContext
Split from #289 per maintainer feedback. The sync-time same-name dedup changes are intentionally not included.