Skip to content

Fix charged species#101

Open
shihchengli wants to merge 2 commits intoxiaoruiDong:mainfrom
shihchengli:fix_charge
Open

Fix charged species#101
shihchengli wants to merge 2 commits intoxiaoruiDong:mainfrom
shihchengli:fix_charge

Conversation

@shihchengli
Copy link
Collaborator

Motivation or Problem

The current fix module doesn't have remedies for charged species. This PR add a function to convert a radical species to charged species based on the added remedies (need to be extended).

Here are some examples:

  1. [Cl] to [Cl-]
Screen Shot 2024-09-30 at 4 05 14 PM
  1. [C]#N to [C-]#N
Screen Shot 2024-09-30 at 4 06 03 PM
  1. methanethiolate
Screen Shot 2024-09-30 at 4 09 01 PM

@xiaoruiDong
Copy link
Owner

Hi @shihchengli, thank you so much! These are good additions. Do you think it makes sense to add an argument for charge (int). Basically, it informs the algorithm about the formal charge of the molecule. Even if it doesn't have an effect at the moment, I hope we can include it as a place holder for future development. And can you merge it into the v1.0/dev branch? Where remedies and fix functions are decoupled. Thanks

@shihchengli shihchengli changed the base branch from main to v1.0/dev October 9, 2024 05:14
@shihchengli shihchengli changed the base branch from v1.0/dev to main October 9, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants