Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Routing Panel in the "Other" tab #703

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Simple Routing Panel in the "Other" tab #703

merged 5 commits into from
Mar 26, 2024

Conversation

jacob-xhio
Copy link
Contributor

This PR addresses the simple case of the following issue: #458. A video sample of the functionality working is shown below, along with a screenshot of the final appearance of the tab.

Video:
https://github.com/xh/toolbox/assets/163027616/ca767af9-3d72-41dc-9d40-84c6de2318ca

Screenshot 2024-03-14 at 2 16 36 PM

Copy link
Member

@haynesjm42 haynesjm42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We might consider an example using the query params form for route parameters as I think that is fairly common, and allows the parameters to be optional so you don't need to create the child route

client-app/src/desktop/AppModel.ts Show resolved Hide resolved
Copy link
Member

@amcclain amcclain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments below - should be quick to look through then let's get it merged 👍

@amcclain amcclain merged commit 047c9c6 into develop Mar 26, 2024
4 checks passed
@amcclain amcclain deleted the routing-tabs branch March 26, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants