-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Routing Panel in the "Other" tab #703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We might consider an example using the query params form for route parameters as I think that is fairly common, and allows the parameters to be optional so you don't need to create the child route
client-app/src/desktop/tabs/other/routing/SimpleRoutingPanel.tsx
Outdated
Show resolved
Hide resolved
d764ef5
to
9bb2dd1
Compare
… changes before grid load
client-app/src/desktop/tabs/other/routing/SimpleRoutingPanel.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments below - should be quick to look through then let's get it merged 👍
This PR addresses the simple case of the following issue: #458. A video sample of the functionality working is shown below, along with a screenshot of the final appearance of the tab.
Video:
https://github.com/xh/toolbox/assets/163027616/ca767af9-3d72-41dc-9d40-84c6de2318ca