Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Review Summary
Dependency-only change: bumps github.com/xgo-dev/llvm from v0.10.3 → v0.10.4 in go.mod/go.sum and removes the temporary replace github.com/xgo-dev/llvm => github.com/cpunion/llvm fork directive now that the CopyFunctionProperties fix (xgo-dev/llvm#61) ships in the upstream release.
No issues found. Code-quality, performance, security, and documentation-accuracy passes all came back clean.
Verified:
- No stale references to
cpunion/llvmorv0.10.3remain anywhere in the repo. (cpuniononly appears as a sample owner string in unrelated CI policy tests under.github/scripts/.) go.sumcarries both theh1:and/go.modhashes forv0.10.4with no orphaned entries;go mod verifypasses.CopyFunctionPropertiesis still exercised (internal/abi/large.go:375,internal/cabi/cabi.go:459), so the bump backs a real requirement rather than being a dead update.- Switching from the personal-account fork pseudo-version to the tagged
xgo-dev/llvm v0.10.4is a modest supply-chain improvement. - The remaining
golang.org/x/toolsreplace is a separate, pre-existing temporary directive and is correctly left untouched.
Non-blocking suggestion: the only thing not verifiable from the diff is that upstream v0.10.4 actually contains the fix — best confirmed by a green build/test run in CI.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use upstream
github.com/xgo-dev/llvm v0.10.4, which includesCopyFunctionPropertiesfrom xgo-dev/llvm#61. Remove the temporary fork replacement introduced by #3061 and refresh checksums.Validation: LLVM binding tests, ABI/C ABI/SSA/intrinsic/allocator-attribute suites,
go mod verify, and the LLGo compiler build pass with LLVM 22.