Skip to content

build: update LLVM bindings to v0.10.4 - #3067

Open
cpunion wants to merge 1 commit into
xgo-dev:mainfrom
cpunion:chore/update-llvm-v0.10.4
Open

cpunion wants to merge 1 commit into
xgo-dev:mainfrom
cpunion:chore/update-llvm-v0.10.4

Conversation

@cpunion

@cpunion cpunion commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

Use upstream github.com/xgo-dev/llvm v0.10.4, which includes CopyFunctionProperties from xgo-dev/llvm#61. Remove the temporary fork replacement introduced by #3061 and refresh checksums.

Validation: LLVM binding tests, ABI/C ABI/SSA/intrinsic/allocator-attribute suites, go mod verify, and the LLGo compiler build pass with LLVM 22.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Dependency-only change: bumps github.com/xgo-dev/llvm from v0.10.3 → v0.10.4 in go.mod/go.sum and removes the temporary replace github.com/xgo-dev/llvm => github.com/cpunion/llvm fork directive now that the CopyFunctionProperties fix (xgo-dev/llvm#61) ships in the upstream release.

No issues found. Code-quality, performance, security, and documentation-accuracy passes all came back clean.

Verified:

  • No stale references to cpunion/llvm or v0.10.3 remain anywhere in the repo. (cpunion only appears as a sample owner string in unrelated CI policy tests under .github/scripts/.)
  • go.sum carries both the h1: and /go.mod hashes for v0.10.4 with no orphaned entries; go mod verify passes.
  • CopyFunctionProperties is still exercised (internal/abi/large.go:375, internal/cabi/cabi.go:459), so the bump backs a real requirement rather than being a dead update.
  • Switching from the personal-account fork pseudo-version to the tagged xgo-dev/llvm v0.10.4 is a modest supply-chain improvement.
  • The remaining golang.org/x/tools replace is a separate, pre-existing temporary directive and is correctly left untouched.

Non-blocking suggestion: the only thing not verifiable from the diff is that upstream v0.10.4 actually contains the fix — best confirmed by a green build/test run in CI.

@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant