-
Notifications
You must be signed in to change notification settings - Fork 15
xen-bugtool: Switch the Python shebang to use Python3 for XS8.4, update README
#158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xen-bugtool: Switch the Python shebang to use Python3 for XS8.4, update README
#158
Conversation
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR transitions xen-bugtool to Python3 on XenServer 8.4 by updating the shebang line and revising the README to reflect Python3-only support. The changes remove references to Python2 compatibility and provide updated FAQs about Python3 stability and implementation details.
- Updates the xen-bugtool shebang to use Python3 instead of Python
- Revises README to document Python3 stability, remove Python2 compatibility references, and add implementation details
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| xen-bugtool | Updates shebang from python to python3 to ensure Python3 execution |
| README.md | Comprehensive update removing Python2 references and adding Python3-focused FAQs and implementation guidance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @bernhardkaindl , XS 8.4 has been released, is there any risk if we do some package upgrade? |
|
@chunjiez, in reply to your question:
Brief IntroThe last Python3 bugs in xen-bugtool were fixed also in March 2024, with no Python3 issues in xen-bugtool in XS9 since. With this, I think that we have good confidence in the Python3 support of xen-bugtool. Complete explanationMy proposal with this PR is to switch xen-bugtool to Python3 on XS8. My justifications for proposing this change for XS8 are:
|
See #158 (comment) for my justification for proposing this switch of xen-bugtool from Python2 to Python3 on XS8 (no change on XS9: XS9 is Python3-only)
Reviewer's Guide
Switch the Python shebang to use Python3 on XS 8.4 as well and update README.md
This PR transitions xen-bugtool to Python3 on XenServer 8.4 by updating its shebang, and refreshes the README to describe Python3-only support, stability guarantees, and updated FAQs.
File-Level Changes
/usr/bin/env python3xen-bugtoolREADME.md