Skip to content

Conversation

@bernhardkaindl
Copy link
Contributor

@bernhardkaindl bernhardkaindl commented Aug 26, 2025

Summary

tox.ini: Cleanup obsolete test environments (from combining Python 2.7 coverage with 3.x coverage)

While at it, also add min_version = 4.6 (4.5 had a bug that needed workarounds previously)

Pull Request Overview by GitHub Copilot Review

This PR removes obsolete Python 2.7 test environments and configuration from the tox setup. The changes update the minimum tox version requirement and clean up all Python 2.7-related dependencies, test environments, and documentation references.

  • Removes all Python 2.7-specific test environments and dependencies
  • Updates minimum tox version to 4.6 and simplifies development setup
  • Cleans up obsolete coverage combination functionality that was specific to Python 2.7

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request.

File Description
tox.ini Removes py27 environments, covcombine section, and updates configuration for modern tox
pyproject.toml Adds test dependencies to coverage, mypy, and pytype extras
README.md Removes Python 2.7 support references and simplifies CI description
CONTRIBUTING.md Removes Python 2.7 development setup instructions and simplifies tox installation

@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #167   +/-   ##
======================================
  Coverage    83.3%   83.3%           
======================================
  Files          23      23           
  Lines        3347    3347           
======================================
  Hits         2790    2790           
  Misses        557     557           

@coveralls
Copy link

coveralls commented Aug 26, 2025

Pull Request Test Coverage Report for Build 17270478682

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.358%

Totals Coverage Status
Change from base Build 17124120104: 0.0%
Covered Lines: 2790
Relevant Lines: 3347

💛 - Coveralls

@bernhardkaindl bernhardkaindl force-pushed the tox-ini-cleanup-obsolete-py27-test-environments branch 2 times, most recently from 8e6b152 to 9a3d671 Compare August 26, 2025 16:11
@bernhardkaindl bernhardkaindl force-pushed the tox-ini-cleanup-obsolete-py27-test-environments branch from 9a3d671 to 0928ea5 Compare August 26, 2025 16:19
@bernhardkaindl bernhardkaindl force-pushed the tox-ini-cleanup-obsolete-py27-test-environments branch from 0400cc5 to 3590b8a Compare August 27, 2025 14:56
@bernhardkaindl bernhardkaindl merged commit 73a92ef into xenserver:master Aug 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants