Skip to content

Conversation

@chunjiez
Copy link
Contributor

@chunjiez chunjiez commented Aug 6, 2025

move DMV common code to python-libs because RPU plugin calls
these functions as well

@chunjiez
Copy link
Contributor Author

chunjiez commented Aug 6, 2025

add @rosslagerwall @DeliZhangX @stephenchengCloud @liulinC to have a review

@rosslagerwall
Copy link
Contributor

I believe this code was previously reviewed. It looks fine to me in general but there are some complaints from the automated tests.

@chunjiez
Copy link
Contributor Author

chunjiez commented Aug 8, 2025

@rosslagerwall I remove some trailing whitespace, then the automated tests noise disappears.

@rosslagerwall
Copy link
Contributor

@rosslagerwall I remove some trailing whitespace, then the automated tests noise disappears.

Unfortunately, I think that was just because the tests hadn't been rerun.

@chunjiez
Copy link
Contributor Author

@rosslagerwall I remove some trailing whitespace, then the automated tests noise disappears.

Unfortunately, I think that was just because the tests hadn't been rerun.

Hi Ross, the README.md is incorrect (INSTALL.md is missing), I trid to call tox/pytest to run unit tests, but it failed. Do you have python-libs code in your local box? If so, could you please check your local code copy contains INSTALL.md or not?

  move DMV common code to python-libs because RPU plugin calls
  these functions as well

Signed-off-by: Chunjie Zhu <[email protected]>
@chunjiez chunjiez force-pushed the master branch 3 times, most recently from 511fdf8 to bb4d6a8 Compare August 21, 2025 01:00
@coveralls
Copy link

coveralls commented Aug 21, 2025

Pull Request Test Coverage Report for Build 17116017958

Details

  • 159 of 183 (86.89%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 83.358%

Changes Missing Coverage Covered Lines Changed/Added Lines %
xcp/dmv.py 159 183 86.89%
Totals Coverage Status
Change from base Build 17094350726: 0.2%
Covered Lines: 2790
Relevant Lines: 3347

💛 - Coveralls

@chunjiez chunjiez force-pushed the master branch 3 times, most recently from a3991ee to 455318f Compare August 21, 2025 01:46
@codecov
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 86.88525% with 24 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
xcp/dmv.py 86.8% 24 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #157     +/-   ##
========================================
+ Coverage    83.1%   83.3%   +0.2%     
========================================
  Files          22      23      +1     
  Lines        3164    3347    +183     
========================================
+ Hits         2631    2790    +159     
- Misses        533     557     +24     
Files with missing lines Coverage Δ
xcp/dmv.py 86.8% <86.8%> (ø)

  add unit test for DMV code

Signed-off-by: Chunjie Zhu <[email protected]>
@chunjiez chunjiez merged commit e1ce4cc into xenserver:master Aug 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants