-
Notifications
You must be signed in to change notification settings - Fork 16
CP-54481: support DMV RPU plugin #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
add @rosslagerwall @DeliZhangX @stephenchengCloud @liulinC to have a review |
|
I believe this code was previously reviewed. It looks fine to me in general but there are some complaints from the automated tests. |
|
@rosslagerwall I remove some trailing whitespace, then the automated tests noise disappears. |
Unfortunately, I think that was just because the tests hadn't been rerun. |
Hi Ross, the README.md is incorrect (INSTALL.md is missing), I trid to call tox/pytest to run unit tests, but it failed. Do you have python-libs code in your local box? If so, could you please check your local code copy contains INSTALL.md or not? |
move DMV common code to python-libs because RPU plugin calls these functions as well Signed-off-by: Chunjie Zhu <[email protected]>
511fdf8 to
bb4d6a8
Compare
Pull Request Test Coverage Report for Build 17116017958Details
💛 - Coveralls |
a3991ee to
455318f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
========================================
+ Coverage 83.1% 83.3% +0.2%
========================================
Files 22 23 +1
Lines 3164 3347 +183
========================================
+ Hits 2631 2790 +159
- Misses 533 557 +24
|
0821f9c to
e0ef18a
Compare
add unit test for DMV code Signed-off-by: Chunjie Zhu <[email protected]>
move DMV common code to python-libs because RPU plugin calls
these functions as well