Skip to content

Provide a few options for busy throbber#280

Open
Lenbok wants to merge 1 commit intoxenodium:mainfrom
Lenbok:feat-selectable-busy-throbber
Open

Provide a few options for busy throbber#280
Lenbok wants to merge 1 commit intoxenodium:mainfrom
Lenbok:feat-selectable-busy-throbber

Conversation

@Lenbok
Copy link
Contributor

@Lenbok Lenbok commented Feb 11, 2026

Just a quickie, see if you like it. I also wondered about renaming agent-shell--status-frame to agent-shell--busy-frame or agent-shell--busy-indicator-frame. I haven't tested under graphical header yet (I use tty).

Checklist

  • I've read the README's Contributing section.
  • I've filed a feature request/discussion for a new feature.
  • My code follows the project style.
  • I've added tests where applicable.
  • I've updated documentation where necessary.
  • I've run M-x checkdoc and M-x byte-compile-file.
  • I've reviewed all code in PR myself and will vouch for its quality.

@Lenbok
Copy link
Contributor Author

Lenbok commented Feb 11, 2026

Also allows eg:

  (with-eval-after-load 'nerd-icons
    (defun agent-shell-make-clock-outline-frames ()
      "Return a vector of nerd-font clock outline icons from one to twelve o'clock.
Uses the nf-md-clock_time_*_outline icons from the nerd-icons package."
      (vconcat
       (mapcar
        (lambda (hour-name)
          (nerd-icons-mdicon
           (format "nf-md-clock_time_%s_outline" hour-name)))
        '("one" "two" "three" "four" "five" "six"
          "seven" "eight" "nine" "ten" "eleven" "twelve"))))
    (setq agent-shell-busy-indicator-frames (agent-shell-make-clock-outline-frames)))

for:

image

(ok that screenshot came out a bit wee)

@xenodium
Copy link
Owner

lol, ok ;)

One thing, since we're now exposing the frames vector, perhaps we should expose it as a list instead which is more commonly known/used.

@xenodium
Copy link
Owner

agent-shell--status-frame to agent-shell--busy-frame or agent-shell--busy-indicator-frame

agent-shell--busy-indicator-frame SGTM

@Lenbok Lenbok force-pushed the feat-selectable-busy-throbber branch from 7853c7e to ddeb020 Compare February 11, 2026 18:17
@Lenbok
Copy link
Contributor Author

Lenbok commented Feb 11, 2026

And :status-frame to :busy-indicator-frame in the header model, or leave as is?

@xenodium
Copy link
Owner

Ah. Yes. That too please.

@Lenbok Lenbok force-pushed the feat-selectable-busy-throbber branch from ddeb020 to 007699d Compare February 11, 2026 18:29
@Lenbok Lenbok force-pushed the feat-selectable-busy-throbber branch from 007699d to 458f3eb Compare February 11, 2026 18:34
@Lenbok
Copy link
Contributor Author

Lenbok commented Feb 11, 2026

Should be good to go.

@Lenbok
Copy link
Contributor Author

Lenbok commented Feb 14, 2026

@xenodium gentle nudge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants