Open
Conversation
Contributor
Author
Owner
|
lol, ok ;) One thing, since we're now exposing the frames vector, perhaps we should expose it as a list instead which is more commonly known/used. |
Owner
agent-shell--busy-indicator-frame SGTM |
7853c7e to
ddeb020
Compare
Contributor
Author
|
And |
Owner
|
Ah. Yes. That too please. |
ddeb020 to
007699d
Compare
007699d to
458f3eb
Compare
Contributor
Author
|
Should be good to go. |
Contributor
Author
|
@xenodium gentle nudge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a quickie, see if you like it. I also wondered about renaming
agent-shell--status-frametoagent-shell--busy-frameoragent-shell--busy-indicator-frame. I haven't tested under graphical header yet (I use tty).Checklist
M-x checkdocandM-x byte-compile-file.