Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3PP] Replace cpptoml with tomlplusplus #2250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gliniak
Copy link
Member

@Gliniak Gliniak commented Feb 26, 2024

Reasoning:

  • Cpptoml is obsolete.

Benefits:

  • toml++ is still developed and maintained.
  • Good documentation.
  • Supports UTF8 with BOM, so tricks skip BOM can be removed.

PS. Not sure if it fully works right now and I'm not sure if functions from toml_internal namespace are still required

@gibbed
Copy link
Member

gibbed commented Feb 26, 2024

Oh cool. Is tomlplusplus a fork of cpptoml? The changes seem really minimal otherwise.

@Gliniak
Copy link
Member Author

Gliniak commented Feb 26, 2024

I don't know, but I agree changes are so small that it looks like a fork.
I was surprised how easy it was to make it work, but I'm still not 100% sure if it works as intended. I saw that in specific cases it works differently. For example it replaces 1.0 with 1

@Gliniak
Copy link
Member Author

Gliniak commented Feb 26, 2024

I double checked it and it seems like it works flawlessly. Please review it just in case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants