Build fixes for old linkers and libbpf versions #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of xdpsock.c into util, we include a call to pthread_create which gets pulled into the build for all binaries. Older linkers choke on this if there's no -lphthread in the build invocation, even when the function calling pthread_create() is not used in the resulting binary. Fix this by adding -lpthread to the linker options in common.mk to make sure it's always available. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
The configure script checks for the presence of bpf_program__flags() in libbpf, but the devbound patches added new functions that call the function without checking the #define. Move things around so the build still works with these old libbpf versions. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Add a couple of ifdefs to the libxdp test binaries to make sure they build with old versions of libbpf. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of build issues with old linkers and old versions of libbpf
(specifically, the versions found on RHEL8).