Skip to content

Update from template #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
12b61ed
Remove unused variable from workflow
AB-xdev Aug 4, 2025
d75370f
[IDEA] Bump checkstyle version
AB-xdev Aug 7, 2025
631ff7d
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 7, 2025
0ec6a33
Update lycheeverse/lychee-action digest to 5c4ee84
xdev-renovate Aug 8, 2025
f368480
Update lycheeverse/lychee-action digest to 5c4ee84
xdev-renovate Aug 8, 2025
3849ad7
Update dependency com.puppycrawl.tools:checkstyle to v11
xdev-renovate Aug 8, 2025
0c0b6d7
Merge pull request #179 from xdev-software/renovate/lycheeverse-lyche…
AB-xdev Aug 8, 2025
ee00029
Merge pull request #180 from xdev-software/renovate/com.puppycrawl.to…
AB-xdev Aug 8, 2025
df23f84
Update actions/checkout action to v5
xdev-renovate Aug 12, 2025
613e5d0
Update actions/checkout action to v5
xdev-renovate Aug 12, 2025
c7e35ec
Merge pull request #4 from xdev-software/renovate/lycheeverse-lychee-…
AB-xdev Aug 12, 2025
acf81d4
Merge pull request #5 from xdev-software/renovate/actions-checkout-5.x
AB-xdev Aug 12, 2025
d5670b4
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 12, 2025
c23e3a8
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 12, 2025
dae27e8
Merge pull request #181 from xdev-software/renovate/actions-checkout-5.x
AB-xdev Aug 12, 2025
019ff58
Add configuration for Intellij PMD plugin
AB-xdev Aug 13, 2025
c89fbec
Merge remote-tracking branch 'origin/update-from-template'
AB-xdev Aug 13, 2025
29aa603
Enable async processing by default
AB-xdev Aug 13, 2025
3ed0401
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 13, 2025
8d53531
Enhance default PMD ruleset
AB-xdev Aug 14, 2025
7baf8f8
Merge branch 'master' into update-from-template-merged
xdev-gh-bot Aug 14, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions .config/pmd/java/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -194,4 +194,52 @@
</rule>

<rule ref="category/java/security.xml"/>

<rule name="AvoidSystemSetterCall"
language="java"
message="Setters of java.lang.System should not be called unless really needed"
class="net.sourceforge.pmd.lang.rule.xpath.XPathRule">
<description>
Calling setters of java.lang.System usually indicates bad design and likely causes unexpected behavior.
For example, it may break when multiple Threads are setting the value.
It may also overwrite user defined options or properties.

Try to pass the value only to the place where it's really needed and use it there accordingly.
</description>
<priority>3</priority>
<properties>
<property name="xpath">
<value>
<![CDATA[
//MethodCall[starts-with(@MethodName,'set')]/TypeExpression[pmd-java:typeIsExactly('java.lang.System')]
]]>
</value>
</property>
</properties>
</rule>

<rule name="JavaObjectSerializationIsUnsafe"
language="java"
message="Using Java Object (De-)Serialization is unsafe and has led to too many security vulnerabilities"
class="net.sourceforge.pmd.lang.rule.xpath.XPathRule">
<description>
Nearly every known usage of (Java) Object Deserialization has resulted in [a security vulnerability](https://cloud.google.com/blog/topics/threat-intelligence/hunting-deserialization-exploits?hl=en).
Vulnerabilities are so common that there are [dedicated projects for exploit payload generation](https://github.com/frohoff/ysoserial).

Java Object Serialization may also fail to deserialize when the underlying classes are changed.

Use proven data interchange formats like JSON instead.
</description>
<priority>2</priority>
<properties>
<property name="xpath">
<value>
<![CDATA[
//ClassDeclaration[@Interface = false()]/ClassBody/FieldDeclaration/VariableDeclarator/VariableId[@Name='serialVersionUID'] |
//ConstructorCall/ClassType[pmd-java:typeIsExactly('java.io.ObjectInputStream') or pmd-java:typeIsExactly('java.io.ObjectOutputStream')]
]]>
</value>
</property>
</properties>
</rule>
</ruleset>
4 changes: 2 additions & 2 deletions .github/workflows/broken-links.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- run: mv .github/.lycheeignore .lycheeignore

- name: Link Checker
id: lychee
uses: lycheeverse/lychee-action@82202e5e9c2f4ef1a55a3d02563e1cb6041e5332 # v2
uses: lycheeverse/lychee-action@5c4ee84814c983aa7164eaee476f014e53ff3963 # v2
with:
fail: false # Don't fail on broken links, create an issue instead

Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/check-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ on:
- 'assets/**'

env:
PRIMARY_MAVEN_MODULE: ${{ github.event.repository.name }}
DEMO_MAVEN_MODULE: ${{ github.event.repository.name }}-demo

jobs:
Expand All @@ -34,7 +33,7 @@ jobs:
distribution: [temurin]

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up JDK
uses: actions/setup-java@v4
Expand Down Expand Up @@ -82,7 +81,7 @@ jobs:
distribution: [temurin]

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up JDK
uses: actions/setup-java@v4
Expand All @@ -105,7 +104,7 @@ jobs:
distribution: [temurin]

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up JDK
uses: actions/setup-java@v4
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up JDK
uses: actions/setup-java@v4
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
outputs:
upload_url: ${{ steps.create-release.outputs.upload_url }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Configure Git
run: |
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
needs: [prepare-release]
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Init Git and pull
run: |
Expand Down Expand Up @@ -153,7 +153,7 @@ jobs:
needs: [prepare-release]
timeout-minutes: 15
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Init Git and pull
run: |
Expand Down Expand Up @@ -184,7 +184,7 @@ jobs:
needs: [publish-maven]
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Init Git and pull
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sync-labels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
sparse-checkout: .github/labels.yml

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5

- name: Set up JDK
uses: actions/setup-java@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update-from-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
update_branch_merged_commit: ${{ steps.manage-branches.outputs.update_branch_merged_commit }}
create_update_branch_merged_pr: ${{ steps.manage-branches.outputs.create_update_branch_merged_pr }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
# Required because otherwise there are always changes detected when executing diff/rev-list
fetch-depth: 0
Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
with:
# Required because otherwise there are always changes detected when executing diff/rev-list
fetch-depth: 0
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ hs_err_pid*
!.idea/saveactions_settings.xml
!.idea/checkstyle-idea.xml
!.idea/externalDependencies.xml
!.idea/PMDPlugin.xml

!.idea/inspectionProfiles/
.idea/inspectionProfiles/*
Expand Down
16 changes: 16 additions & 0 deletions .idea/PMDPlugin.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .idea/checkstyle-idea.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions .idea/saveactions_settings.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>10.26.1</version>
<version>11.0.0</version>
</dependency>
</dependencies>
<configuration>
Expand Down
2 changes: 1 addition & 1 deletion template-placeholder/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>10.26.1</version>
<version>11.0.0</version>
</dependency>
</dependencies>
<configuration>
Expand Down