Various UI improvements and a bug fix. #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rigidity
reviewed
Dec 17, 2024
| @@ -1,6 +1,10 @@ | |||
| <resources xmlns:tools="http://schemas.android.com/tools"> | |||
| <!-- Base application theme. --> | |||
| <style name="Theme.sage_tauri" parent="Theme.MaterialComponents.DayNight.NoActionBar"> | |||
| <!-- <item name="android:statusBarColor">@android:color/transparent</item> --> | |||
| @@ -355,7 +355,7 @@ | |||
| CODE_SIGN_ENTITLEMENTS = "sage-tauri_iOS/sage-tauri_iOS.entitlements"; | |||
| CODE_SIGN_IDENTITY = "iPhone Developer"; | |||
| CODE_SIGN_STYLE = Automatic; | |||
| DEVELOPMENT_TEAM = NQJQRYZZG3; | |||
| DEVELOPMENT_TEAM = 5PSQ3NC8JP; | |||
There was a problem hiding this comment.
Does this need to be changed?
src/components/Layout.tsx
Outdated
| <img src={icon} className='h-6 w-6' /> | ||
| {wallet?.name} | ||
| <img src={icon} className='h-8 w-8' /> | ||
| {/* {wallet?.name} */} |
src/index.css
Outdated
| body, | ||
| #root { | ||
| height: 100%; | ||
| /* overflow: hidden; */ |
There was a problem hiding this comment.
Is this stuff left behind from testing?
index.html
Outdated
| @@ -2,9 +2,17 @@ | |||
| <html lang="en"> | |||
| <head> | |||
| <meta charset="UTF-8" /> | |||
| <meta | |||
| <!-- <meta | |||
There was a problem hiding this comment.
Can this be deleted now?
| [package] | ||
| name = "tauri-plugin-safe-area-insets" | ||
| version = "0.1.0" | ||
| authors = [ "You" ] |
There was a problem hiding this comment.
Probably would be best to set the author/description properly, you can just put yourself here if you want.
It's formatted like Name <email>
|
Went over the comments, removed and reverted not needed changes. Fixed the fee is to high warning to use mojo's now as well after the merge. Also fixed the copybox to have a value and dispValue, otherwise the copy will use the short format address. |
Rigidity
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes:
UI improvements: