update to visualization API 5.0.0#138
Conversation
|
Decision: APPROVE kodiai responseDecision: APPROVE Evidence:
Review Details
Files not fully reviewed (sorted by risk score)
|
5bb09ca to
c9e0d13
Compare
Is to hold the code on longer lines a bit more clean and prevent wrong spaces or tabs.
This code was from the time as add-on was included in Kodi itself and with older ProjectM versions. Value call "g_presets[preset]" no more possible as "g_presets" no more present.
As on ProjectM Version 4 no more presets are present do we need to include into add-on. See also the note here: https://github.com/projectM-visualizer/projectm/blob/master/README.md#presets
Relates to:
```
CMake Deprecation Warning at CMakeLists.txt:2 (cmake_policy):
Compatibility with CMake < 3.10 will be removed from a future version of
CMake.
```
And to have equal to Kodi's used version.
2491bf4 to
a04cbb4
Compare
Add-on update related to Kodi API change defined on xbmc/xbmc#28278
Further done some few cleanups
Runtime tests on Windows and Linux are OK.
Taken few parts from #137 including the presets in add-on to have prepared for projectM v4.x.
The other rquest becomes rebased after this is in.