Skip to content

fix(terminal): fix output loss on cold terminals by moving read() int… - #18

Merged
xavier-arosemena merged 1 commit into
xavier-arosemena:masterfrom
Zoo-Code-Org:main
Jul 14, 2026
Merged

fix(terminal): fix output loss on cold terminals by moving read() int…#18
xavier-arosemena merged 1 commit into
xavier-arosemena:masterfrom
Zoo-Code-Org:main

Conversation

@xavier-arosemena

Copy link
Copy Markdown
Owner

…o onDidStartTerminalShellExecution (Zoo-Code-Org#800) (Zoo-Code-Org#834)

  • fix(terminal): detect D marker directly to recover from lost VSCode shell-integration completion signals

  • fix(terminal): move execution.read() into onDidStartTerminalShellExecution to fix cold-terminal zero-chunk output loss

  • fix(terminal): update unit tests for read()-in-TerminalRegistry architecture

  • fix(terminal): fix Windows CI test timing and improve coverage

  • fix(terminal): address code review findings

  • fix(terminal): address CodeRabbit review findings

Related GitHub Issue

Closes: #

Description

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

…o onDidStartTerminalShellExecution (#800) (#834)

* fix(terminal): detect D marker directly to recover from lost VSCode shell-integration completion signals

* fix(terminal): move execution.read() into onDidStartTerminalShellExecution to fix cold-terminal zero-chunk output loss

* fix(terminal): update unit tests for read()-in-TerminalRegistry architecture

* fix(terminal): fix Windows CI test timing and improve coverage

* fix(terminal): address code review findings

* fix(terminal): address CodeRabbit review findings
@xavier-arosemena xavier-arosemena added this to the Initial launch milestone Jul 14, 2026
@xavier-arosemena xavier-arosemena self-assigned this Jul 14, 2026
@xavier-arosemena xavier-arosemena added the bug Something isn't working label Jul 14, 2026
@xavier-arosemena
xavier-arosemena merged commit d825dbb into xavier-arosemena:master Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants