Grouped, normalized ordering with externals#3
Open
jorenverspeurt wants to merge 8 commits intoxaop:masterfrom
Open
Grouped, normalized ordering with externals#3jorenverspeurt wants to merge 8 commits intoxaop:masterfrom
jorenverspeurt wants to merge 8 commits intoxaop:masterfrom
Conversation
Note that this should probably only happen if the pizza order is too old, but dates are recorded on closing not on opening, so that requires some other changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes made by Joeri as part of his pull request and thus makes that PR obsolete. That, for reference, fixed a bug that could cause accounting problems and did some refactoring.
This set of commits adds a matching algorithm that matches what the user typed after "pizza me" to a pizza in the Pazza menu. It is still possible to order special pizzas (without an ingredient, for example) by typing "pizza me special" and then the entire rest of that message is taken to be a pizza name. The pizzas are shown in a grouped way, for example:
rochus: 3
4formaggi: 1
bruschetta without rucola: 1
It is also possible to order for externals by typing "hubby pizza for ". This works the same as with regular ordering (including "special") but it adds an entry where the "orderer" of a pizza is " for ", so for example if I order a pizza for Jean-Ralphio that would show up as "joren for Jean-Ralphio" in the list. If a user adds a pizza for an external, then that user is the only user that can cancel that order.