Conversation
Update the theme to a cyberpunk style. * **Theme Colors**: - Update `colorPrimary` to `#ff00ff` in `src/common/theme.json` and `src/common/theme.ts`. - Update `colorBgContainer` to `#0a0a0a` in `src/common/theme.json` and `src/common/theme.ts`. - Update `colorBgContainerDark` to `#1a1a1a` in `src/common/theme.json`. - Update `colorBorder` to `#ff00ff` in `src/common/theme.json` and `src/common/theme.ts`. * **Typography**: - Update `fontFamily` to `Neuropol` in `src/common/theme.ts`. - Increase `fontSize` to `16` in `src/common/theme.ts`. * **Glowing Effects**: - Add CSS styles for glowing text and borders using `text-shadow` and `box-shadow` in `src/renderer/luna.scss` and `src/renderer/main.scss`. - Apply glowing effects to headings, buttons, and other important elements in `src/renderer/luna.scss` and `src/renderer/main.scss`. * **Animations and Transitions**: - Add CSS animations and transitions for buttons and links in `src/renderer/luna.scss` and `src/renderer/main.scss`. - Add hover effects and animations for toolbar buttons in `src/renderer/devices/components/Toolbar.module.scss`. - Add hover effects and animations for application buttons and links in `src/renderer/main/components/application/Application.module.scss`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/xaiksan1/aya?shareId=XXXX-XXXX-XXXX-XXXX).
Reviewer's GuideThis PR overhauls the UI theme to a cyberpunk aesthetic by updating core color and typography settings and introducing neon glow effects along with smooth animations and hover transitions across stylesheets. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @xaiksan1 - I've reviewed your changes - here's some feedback:
- A lot of glowing styles and transition rules are duplicated across SCSS files—consider extracting them into shared mixins or utility classes for easier maintenance.
- The theme changes in theme.ts need to be mirrored in theme.json (and vice versa) or ideally driven from a single source of truth to avoid drift.
- Heavy text-shadow and box-shadow effects can impact performance and readability—please review contrast/accessibility and consider a reduced-motion or lower-intensity fallback.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| export const fontFamily = `-apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial, | ||
| 'Noto Sans', sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', | ||
| 'Noto Color Emoji'` | ||
| export const fontFamily = `Neuropol` |
There was a problem hiding this comment.
suggestion: Add fallback fonts for fontFamily
Include system/generic fallback fonts so text displays correctly if Neuropol isn’t installed.
Suggested change
| export const fontFamily = `Neuropol` | |
| export const fontFamily = `Neuropol, -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, 'Helvetica Neue', Arial, 'Noto Sans', sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji'` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the theme to a cyberpunk style.
Theme Colors:
colorPrimaryto#ff00ffinsrc/common/theme.jsonandsrc/common/theme.ts.colorBgContainerto#0a0a0ainsrc/common/theme.jsonandsrc/common/theme.ts.colorBgContainerDarkto#1a1a1ainsrc/common/theme.json.colorBorderto#ff00ffinsrc/common/theme.jsonandsrc/common/theme.ts.Typography:
fontFamilytoNeuropolinsrc/common/theme.ts.fontSizeto16insrc/common/theme.ts.Glowing Effects:
text-shadowandbox-shadowinsrc/renderer/luna.scssandsrc/renderer/main.scss.src/renderer/luna.scssandsrc/renderer/main.scss.Animations and Transitions:
src/renderer/luna.scssandsrc/renderer/main.scss.src/renderer/devices/components/Toolbar.module.scss.src/renderer/main/components/application/Application.module.scss.For more details, open the Copilot Workspace session.
Summary by Sourcery
Introduce a cyberpunk theme by updating the project’s color palette, typography, and adding neon glow styles with interactive animations.
Enhancements:
Chores: