Support subdirectory #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just had the same problem with a sub-directory project. The arg |
4 tasks
| echo "Could not find package.json. Did actions/checkout run?" | ||
| exit 1 | ||
| fi | ||
|
|
||
| forcedVersion=${{inputs.pnpm-version}} | ||
| packageJson=$(cat package.json) |
There was a problem hiding this comment.
this will error if node-version-file is not a json file.
node-version-file is meant for setup-node, rather than just the package.json. it can be an .nvmrc, .node-version, etc
There was a problem hiding this comment.
maybe instead, the working-directory should prefix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the case where package.json is in a subdirectory instead of the repository root.
Real-world use case: https://github.com/ddbj/ddbj-repository/blob/7d2ea35eb1b4a1042fd696ecac83d91f4ab7f8a3/.github/workflows/web.yml#L21
I tried to respect the parameters of the original action as much as possible, but would it be better to define one parameter like
rootand use it to automatically generate thenode-version-file,cache-dependency-pathandworking-directory?