Skip to content

Commit

Permalink
Merge pull request #3 from wyvox/remove-no-lockfile
Browse files Browse the repository at this point in the history
Remove no-lockfile
  • Loading branch information
NullVoxPopuli authored Sep 12, 2023
2 parents dbb149b + c978816 commit 254044c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 27 deletions.
10 changes: 0 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,6 @@ Passes through any args directly to `pnpm install`.
args: '--ignore-scripts --fix-lockfile'
```

### `no-lockfile`

Boolean flag useful for tossing out the lockfile for testing if in-range floating dependency changes have accidentally broken things.

```yaml
- uses: wyvox/action-setup-pnpm@v2
with:
no-lockfile: true
```

## Why?

[`pnpm/action-setup`](https://github.com/pnpm/action-setup/) can install dependencies on its own, but then no cache is used from [`actions/setup-node`](https://github.com/actions/setup-node).
Expand Down
17 changes: 0 additions & 17 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ inputs:
pnpm-version:
description: 'Override the default pnpm version, which defaults to the latest 8.x'
required: false
no-lockfile:
description: 'When testing with floating dependencies, the lockfile will need to be ignored. Enabling this deletes the lockfile before running pnpm install. This is safe as long as further action steps do not commit the change'
required: false
default: false
args:
description: 'Directly pass args to pnpm'
required: false
Expand Down Expand Up @@ -99,19 +95,6 @@ runs:
echo "version=$__resolved_version__" >> $GITHUB_OUTPUT
# It turns out that pnpm does have a flag for this,
# but it's not documented on the website,
# and there is active desire to *not* document on the website.
#
# However, `pnpm install --help` provides the information that was needed for this step to have been avoided.
- name: 'Remove lockfile'
shell: 'bash'
run: |
echo "Detected option --no-lockfile. Lockfile will be deleted before install."
rm -f pnpm-lock.yaml
if: ${{ inputs.no-lockfile == 'true' }}

# The pnpm action:
# - no support for volta
# - no support for cache
Expand Down

0 comments on commit 254044c

Please sign in to comment.