Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Attempt to mount at autoMount initialization #1350

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

1natsu172
Copy link
Contributor

@1natsu172 1natsu172 commented Jan 12, 2025

fix: #1349

As reported in the Issue, missing handling of cases that already existed the anchor at initialization.

Correctly mounted in both navigation and reloading.

Kapture.2025-01-13.at.01.52.53.mp4

Copy link

netlify bot commented Jan 12, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit e48bcd2
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/6783f83c5f3bc2000888c054
😎 Deploy Preview https://deploy-preview-1350--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jan 12, 2025

Open in Stackblitz

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1350

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1350

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1350

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1350

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1350

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1350

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1350

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1350

wxt

npm i https://pkg.pr.new/wxt@1350

commit: e48bcd2

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.10%. Comparing base (fb6a298) to head (e48bcd2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1350      +/-   ##
==========================================
+ Coverage   81.08%   81.10%   +0.02%     
==========================================
  Files         128      128              
  Lines        6285     6288       +3     
  Branches     1068     1069       +1     
==========================================
+ Hits         5096     5100       +4     
+ Misses       1174     1173       -1     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit 5d7e251 into wxt-dev:main Jan 12, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoMount doesn't work on page reload
2 participants