-
Notifications
You must be signed in to change notification settings - Fork 7
Migrate to FastAPI #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Migrate to FastAPI #269
Conversation
server/routes.py
Outdated
|
|
||
|
|
||
| @router.get("/api/locations") | ||
| @cache(expire=300) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this gets invalidated anymore on worker updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I decreased the cache period to 5 seconds and opened an issue for cache invalidation #273.
Wait to merge until after #268 !
Describe what you are trying to do
FastAPI provides a few benefits to Flask:
Steps for review
Test everything, both on host and in docker:
uvicorn shubble:apppython -m server.workernpm run devcd test-client && npm run devpython -m test-server.serverYou can run
docker compose --profile "*" upto run all in docker.Issues
Related to #251