Skip to content

Conversation

@williamschen23
Copy link
Contributor

Describe what you are trying to do

Polling should be done on the mapkitmap level, not a parent component level. This is because if we need only the map, it is impossible with the current configuration without making a parent component, which is stupid. In addition, we re-render the schedule every time the locations change.

Part of #175

Steps for review

Make sure the thing does not break

Issues

Screenshots

Additional Information

@jmccand
Copy link
Collaborator

jmccand commented Dec 13, 2025

The MapkitMap was originally separate from the definitions of the vehicles because we may want to display the map elsewhere, such as for internal data analysis.

@williamschen23
Copy link
Contributor Author

Theres a variable for if you want to not poll. I dont think I changed it here but ill double check

@williamschen23
Copy link
Contributor Author

Also, it doesn't look like the map is active on the data page

@jmccand
Copy link
Collaborator

jmccand commented Dec 13, 2025

Right but how can you choose what to display? The purpose was for this Map component to be used for multiple applications that would provide the data.
This change is fine; we can worry about using the map for alternative purposes later, when we get there.

@williamschen23
Copy link
Contributor Author

williamschen23 commented Dec 13, 2025

Is the data coming from a different API or from another calculation entirely? If its a different API then its a simple change, but if its from extensive cacluation then it will be a bit more complicated. You can also pass API urls / functions entirely, which might solve some issues

@williamschen23 williamschen23 merged commit b4a99d5 into main Dec 13, 2025
3 checks passed
@williamschen23 williamschen23 deleted the fix-polling branch December 13, 2025 02:38
@jmccand
Copy link
Collaborator

jmccand commented Dec 13, 2025

It would probably not be live data. For example, historical locations, or a feature that allows you to replay the shuttle's location.

@williamschen23
Copy link
Contributor Author

williamschen23 commented Dec 13, 2025

Overriding the default behavior seems to be better in that case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants