-
Notifications
You must be signed in to change notification settings - Fork 7
[UI] Live location redesign #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… into live-location-redesign merging main into live location redesign
| import rawAggregatedSchedule from '../data/aggregated_schedule.json'; | ||
|
|
||
| export default function RouteToggle({selectedRoute, setSelectedRoute}) { | ||
| const today = new Date(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use selectedDay to enable day selection
| }; | ||
|
|
||
| export default function Schedule({ selectedRoute, setSelectedRoute }: ScheduleProps) { | ||
| export default function Schedule() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're gonna want to include the selectedRoute and setSelectedRoute here. They are needed for the feature that flips the schedule to a specific route when a user clicks on a stop on the map.
| const [routeNames, setRouteNames] = useState(Object.keys(aggregatedSchedule[selectedDay])); | ||
| const [stopNames, setStopNames] = useState<string[]>([]); | ||
| const [schedule, setSchedule] = useState<AggregatedDaySchedule>(aggregatedSchedule[selectedDay]); | ||
| const [selectedStop, setSelectedStop] = useState("all"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we got rid of selectedStop? This might be from a merge.
| if (!scheduleDiv) return; | ||
|
|
||
| if (selectedDay !== now.getDay()) return; // only scroll if viewing today's schedule | ||
| // if (selectedDay !== now.getDay()) return; // only scroll if viewing today's schedule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete if unneeded.
| padding: 0 20px; | ||
| } | ||
|
|
||
| .banner { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we lost the staging domain banner styling here
Describe what you are trying to do
Redesigned the Shubble header and footer, and the Live Location schedule column.
Steps for review
npm run dev and view the changes.
Issues
Fixes #109
Screenshots


Additional Information