Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Conversation

@andlas98
Copy link
Contributor

@andlas98 andlas98 commented Apr 9, 2019

Major Changes/Fixes:

About page created

Functional pagination element made for view all petitions page (need 7 or more Petition objects to make the element appear).

Edited urls.py to ensure links connect to my webpages (all-petition, create-petition).

Minor Changes/Fixes

Rewrote splash page intro message

Copy link
Contributor

@garoller garoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these pages look good, and there are just some small things that should be changed.
Let me know what you think as far as style changes go, and thank you!

<h4>Create and sign petitions.</h4>
<h4>Make your voice heard by the RPI Student Senate and the campus community.</h4>
<h1 class="pontiac">Let Your Voice Be Heard!</h1>
<br><br><br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the wording change!
I think you could add "Student Senate Petitions" as maybe an <h4> after this line, and I think 3 breaks might be too much space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried adding the "Student Senate Petitions". While the desktop version looks good, the mobile version has text spilling into the rest of the page.
image

Copy link
Contributor Author

@andlas98 andlas98 Apr 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took what you suggested and added a little more to the splash page. Result looks like this:
image
However, the "Recent Petitions" are still off-center.
On desktop, it looks like:
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants