Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5.0] History command #199

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Conversation

archv
Copy link

@archv archv commented Jan 12, 2024

My friends and I wanted to keep the history of played songs in chat as 'Now playing' message keeps removed or updated. Basically it is the same command from #192, but with another name.

/history command is introduced: it prints the same embed as 'Now playing', but with 'Played track' header on every handleTrackStart event.

I have also added defaultPlayerValues to config.js:

defaultPlayerValues: {
  twentyFourSeven: false,
  autoLeave: false,
  autoPause: true,
  autoQueue: false,
  history: false,
}

These values are then applied in players' constructors.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@github-actions github-actions bot added the djs-bot Issue with backend label Jan 12, 2024
@archv
Copy link
Author

archv commented Jan 12, 2024

@BioCla do we set the version to 5.5.0 or 5.4.3?

Copy link
Member

@brianferri brianferri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like it, nice 👍

@brianferri brianferri requested a review from Neko-Life January 12, 2024 14:06
Copy link
Collaborator

@Neko-Life Neko-Life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neko-Life Neko-Life merged commit 045c7cb into wtfnotavailable:develop Jan 12, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
djs-bot Issue with backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants