-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.4.3] Made console logs more clean #198
Conversation
djs-bot/package.json
Outdated
@@ -1,7 +1,7 @@ | |||
{ | |||
"description": "", | |||
"main": "index.js", | |||
"version": "5.4.3", | |||
"version": "5.4.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another bump is another release, you should keep it at .3 and we will only have one release later since all your PR are only refactors. We don't need 2 releases for some patches in one day
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait latest release is 5.4.1 wtf. The new version should stay at 5.4.2 until it's actually released smh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have already pushed a couple of PRs.. What version should I actually set in package.json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well ima let @BioCla make the releases for these version bumps since he's the one merged all your PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll release directly with 5.4.3 after everything is merged. The bumps are correct to be 2 since we can consider one for the new command and the other for the refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New command is new feature and if we actually follow semver the minor version should be incremented, not the patch version.
Well as long as it works, not a problem for me either way
Now console logs look as follows:
Status and versioning classification: