Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4.3] Made console logs more clean #198

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

archv
Copy link

@archv archv commented Jan 12, 2024

Now console logs look as follows:

[10.01.2024 - 21:18]         | Spawned shard 0
[10.01.2024 - 21:18] [WARN ] | Bot running on OPLevel: 1
[10.01.2024 - 21:18] [WARN ] | Debug mode is [ENABLED]!
[10.01.2024 - 21:18] [WARN ] | Booting up the bot...
                               DiscordMusicBot/v5.4.1 (ID: {redacted})
[10.01.2024 - 21:18] [WARN ] | Loading error handlers...
[10.01.2024 - 21:18] [INFO ] | Loaded debug error handlers!
[10.01.2024 - 21:18] [DEBUG] | Music engine "Erela" has been loaded
[10.01.2024 - 21:18] [DEBUG] | Prisma ORM has been loaded
[10.01.2024 - 21:18] [INFO ] | Slash commands have been loaded. Waiting for bot                                                                                                                                                                                                 to finish initializing...
[10.01.2024 - 21:18] [INFO ] | Schedules have been loaded.
[10.01.2024 - 21:18] [INFO ] | Event listeners have been loaded.
[10.01.2024 - 21:18] [INFO ] | WS is now listening on port 3201
[10.01.2024 - 21:18] [INFO ] | Successfully logged in as Arch Music Bot#0893
[10.01.2024 - 21:18] [INFO ] | API is now listening on port 3200
[10.01.2024 - 21:18] [DEBUG] | Node: LocalNode | Lavalink node is connected.
[10.01.2024 - 21:18] [INFO ] | Slash commands have been pushed to application
[10.01.2024 - 21:18] [SILLY] | DiscordMusicBot/v5.4.1 (ID: {redacted})                                                                                                                                                                                                 is online!
prisma:info Starting a postgresql pool with 9 connections.
[11.01.2024 - 00:00] [INFO ] | 'logs.log' has been purged.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@github-actions github-actions bot added the djs-bot Issue with backend label Jan 12, 2024
@@ -1,7 +1,7 @@
{
"description": "",
"main": "index.js",
"version": "5.4.3",
"version": "5.4.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another bump is another release, you should keep it at .3 and we will only have one release later since all your PR are only refactors. We don't need 2 releases for some patches in one day

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait latest release is 5.4.1 wtf. The new version should stay at 5.4.2 until it's actually released smh

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have already pushed a couple of PRs.. What version should I actually set in package.json?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well ima let @BioCla make the releases for these version bumps since he's the one merged all your PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll release directly with 5.4.3 after everything is merged. The bumps are correct to be 2 since we can consider one for the new command and the other for the refactoring

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New command is new feature and if we actually follow semver the minor version should be incremented, not the patch version.

Well as long as it works, not a problem for me either way

@archv archv changed the title [5.4.4] Made console logs more clean [5.4.3] Made console logs more clean Jan 12, 2024
@brianferri brianferri merged commit ad2351d into wtfnotavailable:develop Jan 12, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
djs-bot Issue with backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants