Adding support for mediakeys #193
Conversation
| @@ -507,6 +531,7 @@ const Player: NextPageWithLayout = () => { | |||
|
|
|||
| return ( | |||
| <div className="player-page-container"> | |||
| <audio id="audio" src="https://github.com/anars/blank-audio/raw/master/10-minutes-of-silence.mp3" style={{ display: 'none' }}></audio> | |||
There was a problem hiding this comment.
hmm this is a hack, i wonder if there's anyway to do this without audio element.
Also it only works with chrome it seems, firefox won't set the media applet for me.
There was a problem hiding this comment.
I have checked playing just audio with JS, but it doesn't work. And regarding Firefox, that's weird newer version of Firefox should be compatible https://developer.mozilla.org/en-US/docs/Web/API/MediaSession#browser_compatibility
|
Is firefox works for u @NereaCassian? idk what's wrong with my firefox. It only works on chrome for some reason |
|
anyway i will merge this for now, pretty cool feature. Fixing firefox can be some other day |
It doesn't work in Firefox for me either. It will require some investigation. |
Please describe the changes this PR makes and why it should be merged:
This pull request adds support for using Media Keys through MediaSessions, allowing you to control the bot's playback without having the browser window in focus and without using commands. The only downside is that in order to use the mediaSessions API, the page has to play audio. Therefore, I have added an tag that plays a soundless file as a workaround. I welcome any suggestions for doing this differently
Status and versioning classification: