Skip to content

Introduce Tenant Name to Tenant Management API#290

Merged
SujanSanjula96 merged 7 commits intowso2:masterfrom
HasiniSama:org-handle
May 8, 2025
Merged

Introduce Tenant Name to Tenant Management API#290
SujanSanjula96 merged 7 commits intowso2:masterfrom
HasiniSama:org-handle

Conversation

String.format(ERROR_CODE_DOMAIN_NOT_FOUND.getMessage(), domain));
}
String tenantName = tenantManager.getTenantNameByID(tenant.getId());
tenant.setName(StringUtils.isNotBlank(tenantName) ? tenantName : tenant.getDomain());
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the "domain"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should return the name in the tenant.

Copy link
Copy Markdown
Contributor Author

@HasiniSama HasiniSama Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an intermediate getTenant() call here, which occurs between the tenant entry creation and organization creation. This call fails if we were to add the logic to fetch the name with the tenant.

As a precaution, it was decided to proceed with the current implementation.

@jenkins-is-staging
Copy link
Copy Markdown

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/14901272791

@jenkins-is-staging
Copy link
Copy Markdown

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/14901272791
Status: failure

@jenkins-is-staging
Copy link
Copy Markdown

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/14902235379

@jenkins-is-staging
Copy link
Copy Markdown

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/14902235379
Status: failure

@SujanSanjula96 SujanSanjula96 merged commit 3af032a into wso2:master May 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants