fix: update CI workflow for Node.js 24 + fix better-sqlite3 compilation#2
Merged
Conversation
AxaySharma
commented
Jun 4, 2026
AxaySharma
commented
Contributor
- Pin action versions to latest (checkout@v4.2.2, setup-node@v4.4.0, pnpm@v4)
- Set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true env variable
- Add system deps (python3, make, g++) needed to compile better-sqlite3 on Ubuntu
- Use pnpm rebuild after install instead of --build-from-source flag
- Add pnpm cache to speed up future runs
- Pin action versions to latest (checkout@v4.2.2, setup-node@v4.4.0, pnpm@v4) - Set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true env variable - Add system deps (python3, make, g++) needed to compile better-sqlite3 on Ubuntu - Use pnpm rebuild after install instead of --build-from-source flag - Add pnpm cache to speed up future runs
.join('|') returns string not array — fix type annotation
resolves TS2322 and TS2345 strict mode errors
Contributor
Author
|
Looks good - can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.