Add pre-commit config #2483
Merged
Add pre-commit config #2483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Very much of a fan of these. Do they need any local installation? Or do they 'just work'? |
Member
Author
|
Yea you need to install the pre commit package. Should probably add that to the README. |
Member
Author
|
@copilot Add this to the requirements and readme. |
|
@ericholscher I've opened a new pull request, #2491, to work on those changes. Once the pull request is ready, I'll request review from you. |
plaindocs
approved these changes
Dec 11, 2025
Contributor
plaindocs
left a comment
plaindocs
left a comment
There was a problem hiding this comment.
Should probably merge this.
pre-commit run --all-files
Doesn't work imo, but is less important than changed files
ericholscher
force-pushed
the
pre-commit
branch
from
99fefc8 to
73c35ec
Compare
- Exclude schema files from check-yaml hook (they use multi-document YAML format) - Exclude schema files from yamllint hook - Fix yamale hooks to properly handle file arguments using bash wrapper - Change yamale hooks to use system language instead of python - Exclude schema files from being validated against themselves This resolves all pre-commit validation errors.
ericholscher
force-pushed
the
pre-commit
branch
from
73c35ec to
eadb6a9
Compare
Member
Author
|
@plaindocs Think I have it passing locally now. |
Member
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://writethedocs-www--2483.org.readthedocs.build/