Update Devcontainer to support Local Windows/WSL Developement - #1091
Merged
Merged
Conversation
ebhills
commented
Jul 26, 2026
ebhills
commented
Collaborator
- Update devcontainer.json to current environment and extensions
- Adopt linux line end convention so that local windows development does create back & forth line end diffs.
adopt linux convention so that local windows development does create back & forth line end diffs.
Add a repository-wide `.editorconfig` to standardize encoding, line endings, final newlines, and whitespace handling, with Windows overrides for batch files and preserved trailing whitespace in Markdown. The devcontainer now also installs the EditorConfig VS Code extension so those rules apply automatically in the development environment.
Update the shared devcontainer to use the Python 3.13 base image, install the full editable development environment, and improve VS Code defaults for YAML and Python tooling. Add Windows-specific Docker Desktop startup guidance with a helper script, and sync the Copilot instructions with the current local setup and test dependencies.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the local development experience for WranglesPY by modernizing the VS Code devcontainer configuration (Python 3.13-based) and adding repository-wide line-ending controls to avoid CRLF/LF churn when collaborating from Windows/WSL environments.
Changes:
- Update
.devcontainer/devcontainer.jsonto use the Python 3.13 devcontainer image, install the full dependency set + editable package install, and refresh recommended VS Code extensions/settings (including.recipeas YAML). - Add
.gitattributesand.editorconfigto standardize LF line endings (with CRLF exceptions for.bat/.cmd) and common editor formatting behavior. - Add Windows-focused devcontainer guidance and a helper PowerShell script to wait for Docker Desktop’s Linux engine before reopening the container.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/copilot-instructions.md | Updates internal contributor guidance to reflect the current test/container environment and recipe extensions. |
| .gitattributes | Enforces LF line endings repo-wide (with CRLF for Windows command scripts) and marks common binaries as non-text. |
| .editorconfig | Aligns editor behavior with LF conventions and whitespace handling to reduce cross-platform diffs. |
| .devcontainer/devcontainer.json | Moves devcontainer to Python 3.13, installs full deps + editable package, and refines VS Code settings/extensions for recipes and Python. |
| .devcontainer/wait-for-docker.ps1 | Adds a Windows helper to ensure Docker Desktop’s Linux engine is ready before VS Code evaluates the devcontainer. |
| .devcontainer/README.md | Documents the intended Windows/Codespaces workflows and quick diagnostics for Docker readiness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.