Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in docs that hides {{ attrs }} #215

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

daniboygg
Copy link
Contributor

  • Add django-cotton as a dependency for docs app, otherwise the docker build fails because docs app uses django-cotton

* Add django-cotton as a dependency for docs app, otherwise the
docker build fails because docs app uses django-cotton
whitenoise = "6.2.0"
django-cotton = "^1.3.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniboygg I would probably keep it unpinned as we will always want to develop the docs with the latest cotton?

@wrabit
Copy link
Owner

wrabit commented Nov 6, 2024

Thanks @daniboygg, I still need to work on that process a bit, as if left like this, running and developing the docs project will probably choose to use the version in the container instead of the volume-mapped latest version (as per docker-compose.yml). A rudimentary solution that comes to mind will be to remove the container version after a build.

@daniboygg
Copy link
Contributor Author

@wrabit I think we can insert the dependency as editable to make the docs project get the code inside the mapped volumes

Poetry allows this https://python-poetry.org/docs/cli/#add

[tool.poetry.dependencies]
my-package = {path = "../my/path", develop = true}

@wrabit wrabit merged commit fbee378 into wrabit:main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants