This repository was archived by the owner on Apr 5, 2021. It is now read-only.
Open
Conversation
Owner
|
I appreciate the patch! Could you please also add some tests that a) will keep people from breaking this in the future, and b) convey the purpose of the code? See the tests folder for examples. Thanks! |
Author
|
I'll give it a try when I get a chance - I have never worked with the
testing modules like that so I will try to learn what you're doing there
and add some. It looks like I need to add a test with the type of xml my
changes are supposed to work with and ensure that it detects it correctly.
~jason
…On Sun, Dec 23, 2018 at 10:16 AM William Pietri ***@***.***> wrote:
I appreciate the patch! Could you please also add some tests that a) will
keep people from breaking this in the future, and b) convey the purpose of
the code? See the tests folder for examples. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#61 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGUvkVAVhGV2_9QiwxR43vxa2U8Wi3Khks5u76xegaJpZM4ZfskW>
.
|
…is normally used to tell the type of data in the tag. For LifeSpan responses there is no td, nor child element, but it includes 'type' attrib Status responses have a child element with the tag name indicating the type.
Author
|
Added a few tests, hopefully that helps and also explains what the change is fixing. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial status responses were missing the 'td' attrib so line 462 was causing it to just return instead of calling the handler. Added conditions to check for attribs and tags to assign correct event. Still handles original formatted responses with 'td' present.