[CICD-761] Actually fix excludes #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1786fbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cseeman
force-pushed
the
CICD-761/apm-fix-excludes
branch
from
bca4aa4 to
841bd05
Compare
cseeman
force-pushed
the
CICD-761/apm-fix-excludes
branch
2 times, most recently
from
d7d5b1a to
4f7574b
Compare
Working on making the remote relative solution and tests of make relative remote function. This should help with the excludes not working by changing the folder structure.
Removed out the extra targets in the Docker file. Also outlines next testing steps for scenerios and better checks for the workspace folder structure. Co-authored-By: Michael Day <[email protected]> Co-authored-By: Andrew Matthews <[email protected]>
With the help of Michael, it was determined that the easiest way to make sure that the excludes files is fully used for the rsynch command, is to make sure to use the file name, but not the full file path. This will make sure the files are excluded, no matter which folder location you attempt to deploy to. So default base of the wordpress install will work, or if you use within wp-content or other folder locations. Removing out the testing calls for now too, until we can get a better mocking framework in place to make sure synch_files can be full tested. Co-authored-By: Michael Day <[email protected]>
cseeman
force-pushed
the
CICD-761/apm-fix-excludes
branch
from
4f7574b to
10723dd
Compare
Adding in changeset through the GItHub UI. Locally kept on having npm dependency issues running `npx changeset`
cseeman
commented
Dec 2, 2024
| @@ -0,0 +1,74 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Try removing this commit, delete tests/ structure and integration test and add the removal commit on a graveyward.md for future reference, including docker compose file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
CICD-761
What Are We Doing Here
Customer reports that mu-plugins are being deleted when deploying with the GitHub Action. The plugins that are mentioned as being deleted are already part of our global excludes list in wpengine/site-deploy.
Reported in: wpengine/github-action-wpe-site-deploy#91
To fix this, we are removing out the relative folder structure that was on the excludes list. This will help the rsynch command properly exclude the files, no matter what the folder structure happens to be.