Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds the LICENSE.md markdown file for GPLv2 so that GitHub will recognize and display the licensing, adds the relevant license identifier on necessary files across the repo, and adds in missing header fields on various files.
One thing that I noticed was missing in
wpengine-phpcompat.php
andreadme.txt
was theRequires PHP
header value, so confirming that that should be set to and adding that in would be ideal on top of this PR.Note that this also adds the
LICENSE.md
file to.distignore
though the.distignore
file has some reorganization as part of #282, so assuming 282 is merged in first we'll need a slight refresh to ensure that the license file is properly excluded from distributed/released versions of the plugin.Alternate Designs
none identified, ideally the repo should be explicit with its licensing.
Benefits
Ensures that people looking to understand how this repo is licensed do not need to go digging into various files to see what header fields state the licensing is.
Possible Drawbacks
None identified, so long as GPLv2-or-later is agreed as the proper licensing.
Verification Process
Manually verified via VS Code and GitHub Desktop UI.
Checklist:
Applicable Issues
none identified
Changelog Entry