feat: resolve minimap tile urls in map component #59
Conversation
fallenoak
deleted the
feat-minimap-resolve-tile-urls-in-minimap-component
branch
| const [tilePath, contentPath] = line.split(/\t+/); | ||
| const tilePathParts = tilePath.split(/[/\\]/); | ||
| const tileDirectory = tilePathParts.slice(0, -1).map((t) => t.toLowerCase()).join('/'); | ||
| const tileName = tilePathParts.at(-1).split('.')[0].toLowerCase(); |
There was a problem hiding this comment.
Not entirely sure but have a feeling we may be able to piggyback on path.posix or path.win32 here to do the heavy lifting of converting between one and the other.
There was a problem hiding this comment.
I'm trying to recall if MPQs are path delimiter agnostic or not. If not, I'd agree that we could probably use path.win32.parse to extract the directory and file name. Regardless, I suspect the trs file is always written using \, so path.win32.parse likely always works.
| res.sendStatus(404); | ||
| } | ||
| }); | ||
|
|
| return `${process.env.PIPELINE_URI}/minimap/${mapName}/${tx}/${ty}.blp.png`; | ||
|
|
||
| // TODO use real url | ||
| const unknownTileUrl = `${process.env.PIPELINE_URI}/files/textures/minimap/unknown_${tx}_${ty}`; |
There was a problem hiding this comment.
Given the TODO here, is this a 404 at present? Could this be a generic URL that does not need tx and ty?
There was a problem hiding this comment.
Yeah, this is an intentional 404. The tx and ty is present just to make it easier to trace while we're monkeying a bunch with GameMap.
Do you know if Leaflet accepts null responses from getTileUrl? I haven't looked too closely yet.
This PR removes the redirect mechanism to resolve minimap tile URLs in favor of a tile index API that serves up the mapping of tile path to content path for each tile directory in the
trsfile.The immediate benefit is fewer HTTP requests when rendering minimaps in
spelunker-web. The next phase of this work will involving switching to@wowserhq/format'sBlpclass to render tile.blpfiles directly inspelunker-web.