Repository navigation
fix: point the well-known index at each release's own archives - #64
Merged
Merged
Conversation
workos.com serves the latest release's index.json. With relative archive URLs, an index fetched or cached before a release could resolve to the next release's archives and fail its digest check. Absolute URLs into the release that built the index never change, so the index and its archives always match.
[Medium impact] The PR appears safe to merge. SummaryThe discovery index now points at each release’s own archives, so a cached index keeps its matching downloads after another release.
Acknowledged by nicknisi: updating the live Review checks were limited to reading code; tests were not run.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Review on workos/workos#77885 caught a gap in #62. workos.com serves the latest release's
index.json, and the index listed archives by relative name, so they resolved to the latest release's archives too. An index fetched or cached just before a release could pair with the next release's archives and fail its digest check.https://github.com/workos/skills/releases/download/v0.9.1/workos.tar.gz. Release assets don't change, so any copy of the index, however old, resolves to archives that match its digests.index.json; #77885 drops its archive route to match.Proof
/releases/download/v9/path.npx skills add http://localhost:8799 --skill workos workos-widgets -a claude-code -yread the index from/.well-known/agent-skills/and downloaded both archives from the release path, installing all 76 files.Not proven
The workflow change runs on the next release. To fix the live v0.9.0 index before 0.9.1, dispatch "Publish well-known skills" with
tag: v0.9.0after merging. main will still have the v0.9.0 skill content then, so the regenerated index points at the v0.9.0 archives and their digests match.