Use monaco-editor in WfoJsonCodeBlock #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e277b7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RichieB2B
force-pushed
the
monaco-viewer
branch
from
744fd3e to
3d6f00f
Compare
DutchBen
reviewed
Sep 29, 2025
packages/orchestrator-ui-components/src/components/WfoJsonCodeBlock/WfoJsonCodeBlock.tsx
Show resolved
Hide resolved
DutchBen
reviewed
Sep 29, 2025
packages/orchestrator-ui-components/src/components/WfoJsonCodeBlock/WfoJsonCodeBlock.tsx
Outdated
Show resolved
Hide resolved
|
LGTM. I have to test it locally and have our tester look at it aswell but let's move forward with it |
RichieB2B
force-pushed
the
monaco-viewer
branch
from
3d6f00f to
28fa204
Compare
|
@pboers1988 Can this be merged? |
|
@RichieB2B deferring to @DutchBen, pinged him! |
Mark90
approved these changes
Oct 2, 2025
|
Ruben created a demo environment and it looks great, thanks! |
RichieB2B
force-pushed
the
monaco-viewer
branch
7 times, most recently
from
35921c3 to
ecf6d77
Compare
DutchBen
approved these changes
Oct 9, 2025
Co-authored-by: Ruben van Leeuwen <[email protected]>
DutchBen
force-pushed
the
monaco-viewer
branch
from
700d9e9 to
96ddc3c
Compare
Georgi2704
approved these changes
Oct 9, 2025
packages/orchestrator-ui-components/src/components/WfoWorkflowSteps/WfoStep/WfoStep.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have many large dicts in our workflow states. Very useful for debugging but it is a pain to find the right piece of information. I replaced the
EuiCodeBlockwithmonaco-editorin read-only mode. This gives the benefit of collapsable blocks, sticky scrolling and code-only zoom. The only thing that is missing, is a copy-all button. But Cmd+A + Cmd+C is just as easy.