Add data-testid attributes to wfo form components #2080
+54
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DutchBen
reviewed
Jul 15, 2025
| @@ -16,6 +16,8 @@ export const Header = () => { | |||
|
|
|||
| return pydanticFormSchema?.title && | |||
| pydanticFormSchema.title !== 'unknown' ? ( | |||
| <h3 css={headerStyling}>{pydanticFormSchema?.title}</h3> | |||
| <h3 data-testid="pydantic-form-row" css={headerStyling}> | |||
There was a problem hiding this comment.
I dont think this is a form row. Form-header maybe?
DutchBen
reviewed
Jul 15, 2025
| @@ -91,7 +91,7 @@ export const WfoArrayField = ({ | |||
| }; | |||
|
|
|||
| return ( | |||
| <div css={container}> | |||
| <div data-test={arrayName} css={container}> | |||
There was a problem hiding this comment.
Suggested change
| <div data-test={arrayName} css={container}> | |
| <div data-testid={arrayName} css={container}> |
DutchBen
approved these changes
Jul 15, 2025
|
Add a changeset |
tjeerddie
reviewed
Jul 15, 2025
| @@ -18,6 +18,7 @@ export const Text: PydanticFormControlledElement = ({ | |||
|
|
|||
| return ( | |||
| <EuiFieldText | |||
| data-testid="text-field" | |||
There was a problem hiding this comment.
use formfield.id like the others?
Suggested change
| data-testid="text-field" | |
| data-testid={pydanticFormField.id} |
tjeerddie
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.