Skip to content

Add RBAC info to process and subscription detail endpoints #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025

Conversation

kvklink
Copy link
Member

@kvklink kvklink commented Jul 8, 2025

This PR will allow to frontend to evaluate user permissions in order to disable certain input fields.

Related: workfloworchestrator/orchestrator-ui-library#2058

Closes: #955, #956

Copy link

codspeed-hq bot commented Jul 8, 2025

CodSpeed Performance Report

Merging #990 will not alter performance

Comparing 955-956-add-rbac-info-to-process-schema (8637d97) with main (e292549)

Summary

✅ 12 untouched benchmarks

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.41%. Comparing base (e292549) to head (8637d97).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
orchestrator/graphql/schemas/process.py 54.54% 5 Missing ⚠️
orchestrator/api/api_v1/endpoints/subscriptions.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
+ Coverage   84.37%   84.41%   +0.03%     
==========================================
  Files         213      213              
  Lines       10289    10315      +26     
  Branches     1012     1016       +4     
==========================================
+ Hits         8681     8707      +26     
- Misses       1339     1340       +1     
+ Partials      269      268       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Mark90 Mark90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 1 comment and 1 nitpick!

@Mark90 Mark90 merged commit c628d5c into main Jul 9, 2025
15 of 16 checks passed
@Mark90 Mark90 deleted the 955-956-add-rbac-info-to-process-schema branch July 9, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add Role based access control to running workflows - update subscription workflows endpoint
3 participants