Generator enhancements #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
+ Coverage 83.40% 83.48% +0.07%
==========================================
Files 183 183
Lines 9005 9064 +59
Branches 1472 1487 +15
==========================================
+ Hits 7511 7567 +56
- Misses 1229 1232 +3
Partials 265 265 ☔ View full report in Codecov by Sentry. |
Mark90
force-pushed
the
651-generator-enhancements
branch
4 times, most recently
from
a33fea7 to
a28659c
Compare
pboers1988
approved these changes
Jun 7, 2024
Mark90
force-pushed
the
651-generator-enhancements
branch
6 times, most recently
from
a6316cd to
c70924e
Compare
Mark90
added a commit
to workfloworchestrator/example-orchestrator
that referenced
this pull request
Jun 10, 2024
Updated existing migrations with fixes from workfloworchestrator/orchestrator-core#674
Signed-off-by: Mark90 <[email protected]>
Signed-off-by: Mark90 <[email protected]>
Mark90
force-pushed
the
651-generator-enhancements
branch
from
c70924e to
c9928c0
Compare
mrijk
reviewed
Jun 10, 2024
mrijk
reviewed
Jun 10, 2024
mrijk
approved these changes
Jun 10, 2024
tjeerddie
reviewed
Jun 10, 2024
tjeerddie
reviewed
Jun 10, 2024
tjeerddie
reviewed
Jun 10, 2024
tjeerddie
approved these changes
Jun 10, 2024
product_block: - Fix imports of dependent product blocks in the same product - Detect invalid product block configuration: cyclic or multiple roots product: - Only attach the root product block to the product type migration: - Only relate the root product block to the product, instead of all blocks (product_product_blocks) - Fill depends_on_block_relations in correct order (product_block_relations) - Only create resource types for non-product block fields (product_block_resource_types) Signed-off-by: Mark90 <[email protected]>
Signed-off-by: Mark90 <[email protected]>
Signed-off-by: Mark90 <[email protected]>
- history: show current revision by default - upgrade: make revision a required argument Signed-off-by: Mark90 <[email protected]>
Mark90
force-pushed
the
651-generator-enhancements
branch
from
c9928c0 to
1cdc430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generator enhancements
product_block
product
migration
product_product_blocks)product_block_relations)product_block_resource_types)Please review the updated migrations in the diff, as well as in the example orchestrator workfloworchestrator/example-orchestrator#19
Other
db upgrademandatorydb historycommand to indicate current revision by defaultCloses #651